tetra: Add debug progs command #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olsajiri
added
the
release-note/minor
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
4 times, most recently
from
56a83c1
to
f15f209
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
2 times, most recently
from
da37531
to
f0033f9
Compare
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
10 times, most recently
from
55bef1e
to
370530f
Compare
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
2 times, most recently
from
8ecdf5f
to
d2ad1a2
Compare
lambdanis
approved these changes
Oct 10, 2024
cmd/tetra/debug/progs.go
Outdated
| flags.BoolVar(&cfg.all, "all", false, "Get all programs") | ||
| flags.StringVar(&cfg.lib, "bpf-lib", "bpf/objs/", "Location of Tetragon libs (btf and bpf files)") | ||
| flags.StringVar(&cfg.bpffs, "bpf-dir", "/sys/fs/bpf/tetragon", "Location of bpffs tetragon directory") | ||
| flags.IntVar(&cfg.timeout, "timeout", 1, "Run in one shot mode with argument of the delay in sec") |
There was a problem hiding this comment.
Suggested change
| flags.IntVar(&cfg.timeout, "timeout", 1, "Run in one shot mode with argument of the delay in sec") | |
| flags.IntVar(&cfg.timeout, "timeout", 1, "Interval in seconds (delay in one shot mode)") |
nit, the help text sounds like it automatically enabled the one shot mode
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
4 times, most recently
from
607516b
to
1754996
Compare
Adding tetra debug progs command that enables bpf program stats
and collects them for running programs.
The deault output looks like:
# ./tetra debug progs --once
2024-10-05 20:59:26.75755952 +0000 UTC m=+1.037895215
Ovh(%) Id Cnt Time Name Pin
0.00 1934 0 0 event_execve /sys/fs/bpf/tetragon/__base__/event_execve/prog
0.00 1929 0 0 event_exit_acct_process /sys/fs/bpf/tetragon/__base__/event_exit/prog
0.00 1931 0 0 event_wake_up_new_task /sys/fs/bpf/tetragon/__base__/kprobe_pid_clear/prog
0.00 1937 0 0 tg_kp_bprm_committing_creds /sys/fs/bpf/tetragon/__base__/tg_kp_bprm_committing_creds/prog
It provides several options to control timeout and repetition,
all should be described in help.
Signed-off-by: Jiri Olsa <[email protected]>
We need proper attach string or uprobe programs because they will be part of overhead metrics. Storing attach for standard uprobe, like: Attach="/home/jolsa/tetragon/contrib/tester-progs/nop main" and uprobe multi, like: Attach="uprobe_multi (1 functions)" Signed-off-by: Jiri Olsa <[email protected]>
We need that for proper overhead metrics. Signed-off-by: Jiri Olsa <[email protected]>
olsajiri
force-pushed
the
pr/olsajiri/overhead
branch
from
1754996
to
c4419e0
Compare
|
ugh, forgot to push the bpf prog iter bits, it's there now, sorry @lambdanis |
lambdanis
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tetra debug progs command that enables bpf program stats and collects them for running programs.
The deault output looks like:
It provides several options to control timeout and repetition, all should be described in help.
TODO will add a way to dump full bpf program name