Memory optimizations: remove BTF and kallsyms caches #2937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/misc
We use ksyms for checking the proper exit hooks when loading the base sensor. Furthermore, we use it when we add a kprobe policy for a function that is part of a kernel module. Having that always in memory, uses a lot of memory. This patch makes the read of ksyms when we need that. Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/memory_opts
branch
2 times, most recently
from
247482f
to
59386c6
Compare
tpapagian
force-pushed
the
pr/apapag/memory_opts
branch
from
59386c6
to
573845f
Compare
kkourt
approved these changes
Sep 20, 2024
mtardy
approved these changes
Sep 20, 2024
Comment on lines
-22
to
23
| var ( | ||
| kernelSymbols *Ksyms | ||
| setKernelSymbols sync.Once | ||
| ) | ||
|
|
||
| func KernelSymbols() (*Ksyms, error) { | ||
| var err error | ||
| setKernelSymbols.Do(func() { | ||
| kernelSymbols, err = NewKsyms(option.Config.ProcFS) | ||
| }) | ||
| return kernelSymbols, err | ||
| return NewKsyms(option.Config.ProcFS) | ||
| } |
There was a problem hiding this comment.
nit: Could we add a comment there? it might be a little bit confusing why we had this function in the first place.
| @@ -124,6 +125,9 @@ func (s *Sensor) Load(bpfDir string) error { | |||
| progsAdd(s.Progs) | |||
| AllMaps = append(AllMaps, s.Maps...) | |||
|
|
|||
| // cleanup the BTF once we have loaded all sensor's program | |||
| btf.FlushKernelSpec() | |||
mtardy
changed the title
jrfastab
approved these changes
Sep 20, 2024
This patch flushes the BTF when we complete the loading of a sensor. Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/memory_opts
branch
from
573845f
to
b04a57f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not cache large objects like the BTF and ksyms. Reload them when needed.
Before:
After:
