Make event cache tunable #2928
Merged
Make event cache tunable #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tpapagian
added
the
release-note/misc
tpapagian
force-pushed
the
pr/apapag/eventcache-conf
branch
from
8a06e70
to
7ff711c
Compare
tpapagian
force-pushed
the
pr/apapag/eventcache-conf
branch
3 times, most recently
from
eb2d780
to
649da64
Compare
mtardy
approved these changes
Sep 17, 2024
These include the number of retries and the delay between them.
New command line arguments to do that:
--event-cache-retries int Number of retries for event cache (default 15)
--event-cache-retry-delay int Delay in seconds between event cache retries (default 2)
Signed-off-by: Anastasios Papagiannis <[email protected]>
The previous patch makes EventCache configurable. This allows to reduce some delays in the tests. Signed-off-by: Anastasios Papagiannis <[email protected]>
Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/eventcache-conf
branch
from
649da64
to
b2f6473
Compare
There may be cases where the k8s watcher is overloaded and the default settings may not enough. On the other hand, having a large delay may result on waiting too much for getting events (even without pod info). So I believe that this is a good idea to allow users to configure that based on their needs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the event cache tunable. This includes the number of retries and the delay between each retry. For this reason we introduce 2 new command line flags:
This PR does not change the default values of those.
We also export those values through the Helm Chart.