Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Assorted fixes #2906

Merged
merged 2 commits into from
Sep 13, 2024
Merged

tetragon: Assorted fixes #2906

merged 2 commits into from
Sep 13, 2024

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Sep 10, 2024

fix for TestPolicyListingWhileLoadUnload and TestLoader tests

Fixes: #2576

With updated kernel it works again, let's enable it
and hope it fails again.

Signed-off-by: Jiri Olsa <[email protected]>
The delayed sensor is used in TestPolicyListingWhileLoadUnload
to check on loaded sensors states with following code path.

  - one go routine is periodically listing sensors and when found
    it calls unblock on delayed sensor that sends data on sensor's
    channel

  - another go routine is adding sensor and calls Load on delayed
    sensor to receive data from the sensors channel

Currently the test can fail in delayed sensor's unblock if the
receiving side is not ready yet, which is completely ok, because
sensor is first added in the collections and only after the Load
method is called.

Instead of failing immediately adding 10 seconds timer on
delayed sensor's unblock select.

Fixes: #2576
Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit ccdfd2b
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66e081bc3808940008b6b778
😎 Deploy Preview https://deploy-preview-2906--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri marked this pull request as ready for review September 10, 2024 19:25
@olsajiri olsajiri requested a review from a team as a code owner September 10, 2024 19:25
@kkourt kkourt merged commit d54fb6c into main Sep 13, 2024
46 of 47 checks passed
@kkourt kkourt deleted the pr/olsajiri/fixes branch September 13, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New TestPolicyListingWhileLoadUnload introduces a flake
3 participants