Fix clone event caching due to missing pod info #2899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpapagian
added
the
release-note/misc
The eventcache API provides 2 handlers. These are: RetryInternal -> called to setup process information Retry -> called to setup pod information In the case of clone events, we used to have en empty implementation on the Retry handler. This results in an issue with missing pod information which is described in detail here: #2902 This patch provides the proper Retry implementation to handle also those cases. FIXES: #2902 Signed-off-by: Anastasios Papagiannis <[email protected]>
tpapagian
force-pushed
the
pr/apapag/fix_clone_caching
branch
from
b22d08c
to
12adb18
Compare
tpapagian
added
release-note/bug
kevsecurity
approved these changes
Sep 10, 2024
tixxdz
approved these changes
Sep 10, 2024
kkourt
added
needs-backport/1.0
tpapagian
added
backport-done/1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
eventcacheAPI provides 2 handlers.These are:
RetryInternal-> called to setup process informationRetry-> called to setup pod informationIn the case of clone events, we used to have en empty implementation on the
Retryhandler. This results in an issue with missing pod information which is described in detail here: #2902This patch provides the proper
Retryimplementation to handle also those cases.FIXES: #2902