Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon:tarball: docker oci tarball fix #2161

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

tixxdz
Copy link
Member

@tixxdz tixxdz commented Feb 28, 2024

closes: #2163

Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz requested review from willfindlay and a team as code owners February 28, 2024 11:57
@tixxdz tixxdz marked this pull request as draft February 28, 2024 11:57
@tixxdz tixxdz added the release-note/minor This PR introduces a minor user-visible change label Feb 28, 2024
@tixxdz tixxdz force-pushed the pr/tixxdz/02-2024-docker-oci-tarball-fix branch 7 times, most recently from 9e7f558 to 5af5487 Compare February 28, 2024 16:29
Starting from Docker 25.0 , the save command will dump the image
layers in OCI compatible format: moby/moby#44598

This breaks our tarball build that was using the 'layer.tar' file to
construct the final tarball.

Let's make the target a bit smart so it can handle all variants by
parsing the docker manifest.json file to find the layer and use it.

The 'make tarball' now requires jq for simplicity.

Signed-off-by: Djalal Harouni <[email protected]>
@tixxdz tixxdz force-pushed the pr/tixxdz/02-2024-docker-oci-tarball-fix branch from 5af5487 to 708ac75 Compare February 28, 2024 16:30
@tixxdz tixxdz marked this pull request as ready for review February 28, 2024 16:30
@tixxdz tixxdz merged commit 5cc9bce into main Feb 28, 2024
32 checks passed
@tixxdz tixxdz deleted the pr/tixxdz/02-2024-docker-oci-tarball-fix branch February 28, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tetragon: tarball build breaks on docker 25.0
2 participants