workflows: fix validate CRD by fetching all git repo history #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
area/ci
willfindlay
approved these changes
Feb 5, 2024
🤔 |
mtardy
force-pushed
the
pr/mtardy/fix-crd-workflow
branch
from
08cc290
to
6150c28
Compare
willfindlay
approved these changes
Feb 5, 2024
yep that's what I'm trying to fix, it seems that this thing was merged without ever working :( |
|
That's tragic |
Also add a trigger on the workflow file to test. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/fix-crd-workflow
branch
from
6150c28
to
c3d3b62
Compare
|
Needs another |
|
Ah you're too fast for me 🏃 |
willfindlay
approved these changes
Feb 5, 2024
|
so much approving, thanks William!!! |
tixxdz
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #2063.