golangci-lint: remove Dockerfile.golangci-lint and update renovate config #2044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtardy
added
the
release-note/dependency
We no longer need the special golangci-lint docker image since we now build without CGO and can use the upstream image directly. Secondly, this adds GOTOOLCHAIN=auto to the golangci-lint container since it might ship older Go toolchain than our go.mod directive and thus not being able to build the project. Signed-off-by: Mahe Tardy <[email protected]>
This was removed in favor of using the full docker image reference in previous commits. Signed-off-by: Mahe Tardy <[email protected]>
Instead of focusing only on upgrading a specific line starting with `GO_IMAGE`, the new regex allow it to work with any variable name. Signed-off-by: Mahe Tardy <[email protected]>
mtardy
force-pushed
the
pr/mtardy/renovate-regex-makefile
branch
from
64dca44
to
b6428a1
Compare
mtardy
changed the title
kkourt
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits.