-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Add uprobe multi support #1914
Conversation
496f82b
to
5c1ff8c
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
503d8fc
to
9c509ad
Compare
338d415
to
4fc0d21
Compare
4fc0d21
to
370051e
Compare
370051e
to
1113839
Compare
7992c37
to
6d1da2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
pkg/bpf/detect.go
Outdated
return false | ||
} | ||
|
||
// need cilium/ebp fix, can't pass just addresses without symbol |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an issue for this on cilium/ebpf? Would be nice to have a reference to check when this is fixed and update the code.
nit: typo -> cilium/ebp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, the comment is no longer valid, it got fixed as preparation for uprobe multi support in ebpf/cilium lib
now it is:
func (ex *Executable) addresses(symbols []string, addresses, offsets []uint64) ([]uint64, error) {
n := len(symbols)
if n == 0 {
n = len(addresses)
}
will remove the comment and fix the typo, thanks
Looks good fix small typo and merge imo. |
The MultiRelinkUnloader unloader keeps and unloads multiple links, which will be needed for multi uprobes. Signed-off-by: Jiri Olsa <[email protected]>
To detect uprobe multi link. Signed-off-by: Jiri Olsa <[email protected]>
Compile new bpf_multi_uprobe_v60.o object with __MULTI_KPROBE defined. It will be used for uprobe multi sensor. Signed-off-by: Jiri Olsa <[email protected]>
Adding LoadMultiUprobeProgram function to load uprobe multi programs. Signed-off-by: Jiri Olsa <[email protected]>
Adding support to load multiple uprobes via uprobes multi interface. Signed-off-by: Jiri Olsa <[email protected]>
Adding support to process options passed in spec for uprobe sensor. At the moment the only supported option is to disable uprobe multi. Signed-off-by: Jiri Olsa <[email protected]>
Signed-off-by: Jiri Olsa <[email protected]>
6d1da2b
to
2de8e75
Compare
cilium/ebpf changes cilium/ebpf#1269