Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Add uprobe multi support #1914

Merged
merged 7 commits into from
Apr 1, 2024
Merged

tetragon: Add uprobe multi support #1914

merged 7 commits into from
Apr 1, 2024

Conversation

olsajiri
Copy link
Contributor

@olsajiri olsajiri commented Dec 23, 2023

cilium/ebpf changes cilium/ebpf#1269

tracing: add multi-link uprobe support

@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Dec 23, 2023
@olsajiri olsajiri force-pushed the pr/olsajiri/uprobe_multi branch 4 times, most recently from 496f82b to 5c1ff8c Compare December 26, 2023 14:03
Copy link

netlify bot commented Dec 27, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 8cd9cb9
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/66086980301589000826be61
😎 Deploy Preview https://deploy-preview-1914--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@olsajiri olsajiri force-pushed the pr/olsajiri/uprobe_multi branch 2 times, most recently from 503d8fc to 9c509ad Compare December 27, 2023 11:03
@olsajiri olsajiri force-pushed the pr/olsajiri/uprobe_multi branch 4 times, most recently from 338d415 to 4fc0d21 Compare February 6, 2024 16:35
@olsajiri olsajiri force-pushed the pr/olsajiri/uprobe_multi branch 3 times, most recently from 7992c37 to 6d1da2b Compare March 30, 2024 19:58
@olsajiri olsajiri marked this pull request as ready for review March 30, 2024 21:07
@olsajiri olsajiri requested review from mtardy and a team as code owners March 30, 2024 21:07
Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

return false
}

// need cilium/ebp fix, can't pass just addresses without symbol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue for this on cilium/ebpf? Would be nice to have a reference to check when this is fixed and update the code.

nit: typo -> cilium/ebp

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, the comment is no longer valid, it got fixed as preparation for uprobe multi support in ebpf/cilium lib
now it is:

func (ex *Executable) addresses(symbols []string, addresses, offsets []uint64) ([]uint64, error) {
        n := len(symbols)
        if n == 0 {
                n = len(addresses)
        }

will remove the comment and fix the typo, thanks

@jrfastab
Copy link
Contributor

jrfastab commented Apr 1, 2024

Looks good fix small typo and merge imo.

The MultiRelinkUnloader unloader keeps and unloads multiple links,
which will be needed for multi uprobes.

Signed-off-by: Jiri Olsa <[email protected]>
To detect uprobe multi link.

Signed-off-by: Jiri Olsa <[email protected]>
Compile new bpf_multi_uprobe_v60.o object with __MULTI_KPROBE
defined. It will be used for uprobe multi sensor.

Signed-off-by: Jiri Olsa <[email protected]>
Adding LoadMultiUprobeProgram function to load uprobe multi
programs.

Signed-off-by: Jiri Olsa <[email protected]>
Adding support to load multiple uprobes via uprobes multi interface.

Signed-off-by: Jiri Olsa <[email protected]>
Adding support to process options passed in spec for uprobe sensor.

At the moment the only supported option is to disable uprobe multi.

Signed-off-by: Jiri Olsa <[email protected]>
@olsajiri olsajiri merged commit 1d6d208 into main Apr 1, 2024
41 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/uprobe_multi branch April 1, 2024 21:59
@kkourt kkourt added release-note/major This PR introduces major new functionality and removed release-note/minor This PR introduces a minor user-visible change labels Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/major This PR introduces major new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants