Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: add independent go-version for setup-go actions #1852

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Dec 6, 2023

This reverts commit dd5ddc2.

This was a good idea but #1748 impacts this as we no longer update the patch version in the go.mod directive. Thus the CI is running outdated Go versions.

@mtardy mtardy added the release-note/ci This PR makes changes to the CI. label Dec 6, 2023
@mtardy mtardy requested review from willfindlay and a team as code owners December 6, 2023 10:26
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit f1f896c
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/65704c6fd94d390008d8a4cb
😎 Deploy Preview https://deploy-preview-1852--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This reverts commit dd5ddc2.

This was a good idea but #1748 impacts this as we no longer update the
patch version in the go.mod directive. Thus the CI is running outdated
Go versions.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy mtardy force-pushed the pr/mtardy/revert-go-version-gomod branch from f1f896c to 4d2f0f3 Compare December 6, 2023 10:28
@mtardy mtardy force-pushed the pr/mtardy/revert-go-version-gomod branch from 4d2f0f3 to 0182f01 Compare December 6, 2023 15:14
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

struggle

@mtardy mtardy merged commit b42efe4 into main Dec 6, 2023
32 checks passed
@mtardy mtardy deleted the pr/mtardy/revert-go-version-gomod branch December 6, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants