make:image: support arm64 cross compile #1796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should support cross compile container image. It does not use docker multiplatfor buildx It uses the compiled arm64 bpftool with llvm Signed-off-by: Djalal Harouni <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tixxdz
added
the
release-note/minor
|
This is handled by #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should support cross compile container image.
It does not use docker multiplatfor buildx
It uses the compiled arm64 bpftool with llvm , Todo: fix it so we use it only on cross compile in case bpftool still fails
The make tarball is just make image, when make image works then make tarball should work transparently, but in case with multiplatfor docker buildx, then we just need to select the right image with arch as suffix