Refactor and extend the interface for metrics with configurable labels #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambdanis
added
area/metrics
lambdanis
force-pushed
the
pr/lambdanis/metrics-api
branch
3 times, most recently
from
e4a96e9
to
4b4010f
Compare
This is a non-functional change, only reorganising code for easier development. Signed-off-by: Anna Kapuscinska <[email protected]>
This commit chnanges the logic behind counters with configurable labels. It introduces a new type, labelFilter, which defines the known and enabled labels. The labelFilter is included in the granularCounter type, which exposes filter and mustFilter methods. With this approach, the label filtering doesn't rely on the global config option. Additionally, granularCounter exposes WithLabelValues method, so that metric updates can be done with the same interface as for prometheus CounterVec. Technically it is a breaking change, but only developer facing. Signed-off-by: Anna Kapuscinska <[email protected]>
Signed-off-by: Anna Kapuscinska <[email protected]>
lambdanis
force-pushed
the
pr/lambdanis/metrics-api
branch
from
4b4010f
to
b7cbfee
Compare
jrfastab
approved these changes
Oct 12, 2023
mtardy
reviewed
Oct 13, 2023
| "github.com/cilium/tetragon/pkg/metrics/consts" | ||
| "github.com/cilium/tetragon/pkg/option" | ||
| "github.com/prometheus/client_golang/prometheus" | ||
| "golang.org/x/exp/slices" |
There was a problem hiding this comment.
hey @lambdanis I think you reintroduced golang.org/x/exp/slices here, I don't know if it's intended since you removed that #1560.
There was a problem hiding this comment.
I just rebased one of my PR and noticed that go.mod needed to include the new dependency.
There was a problem hiding this comment.
I really don't understand how the tests pass here and not on my rebased PR... https://github.com/cilium/tetragon/actions/runs/6508448671/job/17677830078?pr=1562#step:5:610
There was a problem hiding this comment.
I think the tests passed on this PR a while ago, before some deps got updated?
Anyway, thanks for fixing this import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits for details.