-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Deprecate Pod.labels field #1363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deprecate Pod.labels field which contains Cilium identity labels, and document that it has been replaced by Pod.pod_labels field. Ref: #794 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
force-pushed
the
pr/michi/deprecation-struggle
branch
from
August 16, 2023 22:37
0235473
to
b7813fb
Compare
kkourt
approved these changes
Aug 17, 2023
rolinh
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michi-covalent
added a commit
that referenced
this pull request
Sep 5, 2023
Pod.Labels field got deprecated in v0.11 [^1], so we can stop setting the field in main branch. This means that Tetragon no longer depends on the Cilium state, so we don't have to synchronize it anymore. This patch removes tetragon.enableCiliumAPI Helm value and deletes packages related to Cilium state synchronization. [^1]: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Sep 6, 2023
Pod.Labels field got deprecated in v0.11 [^1], so we can stop setting the field in main branch. This means that Tetragon no longer depends on the Cilium state, so we don't have to synchronize it anymore. This patch removes tetragon.enableCiliumAPI Helm value and deletes packages related to Cilium state synchronization. [^1]: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1. Ref: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1. Ref: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1. Ref: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1. Ref: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
michi-covalent
added a commit
that referenced
this pull request
Dec 6, 2023
The pod.labels field got deprecated in v1.0. Let's remove it for v1.1. Ref: #1363 Signed-off-by: Michi Mutsuzaki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate Pod.labels field which contains Cilium identity labels, and document that it has been replaced by Pod.pod_labels field.
Ref: #794