Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sigstore/cosign-installer update and ignore it #1161

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

mtardy
Copy link
Member

@mtardy mtardy commented Jun 27, 2023

No description provided.

Revert update from ac11ac3 that broke
the build and is difficult to test pre-merge.

Signed-off-by: Mahe Tardy <[email protected]>
@mtardy
Copy link
Member Author

mtardy commented Jun 27, 2023

btw a lot of tests will fail because the image build is broken (this patch is fixing it) and it is using pull_request_target as trigger.

Copy link
Contributor

@willfindlay willfindlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@mtardy
Copy link
Member Author

mtardy commented Jun 27, 2023

Let's not wait for the tests to fail and merge this directly.

@mtardy mtardy merged commit db2649d into main Jun 27, 2023
1 check failed
@mtardy mtardy deleted the pr/mtardy/cosign-hell branch June 27, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants