observer_test_helper: properly clenup base sensor

During a test failure, where loading a sensor failed, the next test would also fail because the base sensor existed already. Fix this by registering a cleanup function to unload the base sensor rogjt after we load it. Signed-off-by: Kornilios Kourtis <[email protected]>
cilium · Sep 12, 2024 · 02caee5 · 02caee5
1 parent 28d7d30
commit 02caee5
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/observer/observertesthelper/observer_test_helper.go b/pkg/observer/observertesthelper/observer_test_helper.go
@@ -423,6 +423,9 @@ func loadObserver(tb testing.TB, ctx context.Context, base *sensors.Sensor,
 	if err := base.Load(option.Config.BpfDir); err != nil {
 		tb.Fatalf("Load base error: %s\n", err)
 	}
+	tb.Cleanup(func() {
+		base.Unload()
+	})
 
 	if tp != nil {
 		if err := observer.GetSensorManager().AddTracingPolicy(ctx, tp); err != nil {
@@ -432,7 +435,6 @@ func loadObserver(tb testing.TB, ctx context.Context, base *sensors.Sensor,
 
 	tb.Cleanup(func() {
 		observer.RemoveSensors(ctx)
-		base.Unload()
 	})
 	return nil
 }