Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: remove test helper setup #1842

Merged
merged 1 commit into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/app/templates/public-pages/docs/migrate-7-0-to-8-0.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@
See our <a href="https://github.com/cibernox/ember-power-select/blob/8ffe2bc74373f7b1ec8e244bff218c39ba70c19e/ember-power-select/src/components/power-select/options.hbs#L23" target="_blank" rel="noopener noreferrer">options.hbs</a>
</p>
</li>
<li>
<p>Test helpers: The <code>registerPowerSelectHelpers</code> is not required anymore. Please, remove this from <code>/tests/helpers/start-app.js</code>.</p>
</li>
<li>
<p>Helper: The helper <code>ember-power-select-is-selected</code> was renamed to <code>ember-power-select-is-equal</code>. If you have used in your custom components, you need to replace it</p>
</li>
Expand Down
17 changes: 0 additions & 17 deletions docs/app/templates/public-pages/docs/test-helpers.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,6 @@
that make it nicer to interact with the component in acceptance tests.
</p>

<p>
To use those helpers in acceptance tests that use <code>moduleForAcceptance</code>, you need to register them in the <code>/tests/helpers/start-app.js</code>
file.
</p>

<p>
For that import the registration function and invoke it immedialty.
</p>

<CodeSnippet @name="test-helpers-1-js.js"/>

<p>
However if you are using the new testing API described in
<a href="https://github.com/emberjs/rfcs/pull/232">RFC 232</a>, available in ember-cli-qunit >= 4.2 and ember-cli-mocha >= 0.15.0, then you just can explicitly import those
helpers where needed (even in integration tests!)
</p>

<CodeSnippet @name="test-helpers-10-js.js"/>
wozny1989 marked this conversation as resolved.
Show resolved Hide resolved

<h2 class="t3"><code>selectChoose(cssPath, optionTextOrOptionSelector, index?)</code></h2>
Expand Down
9 changes: 0 additions & 9 deletions docs/app/templates/snippets/test-helpers-1-js.js

This file was deleted.