Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper div around options & afterOptionsComponent #1156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nickschot
Copy link
Contributor

@cibernox this is the second feature request I made in Discord. This enables the following change: https://github.com/weddingshoppe/ember-model-select/pull/6/files#diff-6cd7a1538e5e1eb6201624d486136991 meaning the loading mask height is independent of any style changes that are made to the search component.

@nickschot
Copy link
Contributor Author

Heh, it seems something odd happened with rebasing. Just need to look at the power-select.hbs change (which is the div).

@RobbieTheWagner
Copy link
Collaborator

@nickschot I realize this is super old, but could you please rebase and fix conflicts?

@nickschot
Copy link
Contributor Author

nickschot commented Oct 1, 2022

@nickschot I realize this is super old, but could you please rebase and fix conflicts?

Not sure what was up with my branch, was a bit weird. But since it's a one liner I've just started afresh master again. Should be fixed.

edit: oh my comment from 2018 already said something weird was going on 😂

@RobbieTheWagner
Copy link
Collaborator

Thanks @nickschot! Is there any possibility this would break things for some people or not? I'm trying to help out maintaining things here, but I am not super familiar with the internals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants