Update ember-basic-dropdown to v8.0.0-beta.8 (#1726)

cibernox · Mar 5, 2024 · ff38c7a · ff38c7a
1 parent ebaf455
commit ff38c7a
Show file tree

Hide file tree

Showing 5 changed files with 1,464 additions and 703 deletions.
diff --git a/docs/package.json b/docs/package.json
@@ -75,7 +75,7 @@
     "broccoli-asset-rev": "^3.0.0",
     "concurrently": "^8.2.2",
     "ember-auto-import": "^2.7.2",
-    "ember-basic-dropdown": "8.0.0-beta.7",
+    "ember-basic-dropdown": "8.0.0-beta.8",
     "ember-concurrency": "^4.0.0",
     "ember-cli": "~5.6.0",
     "ember-cli-app-version": "^6.0.1",

diff --git a/ember-power-select/package.json b/ember-power-select/package.json
@@ -119,7 +119,7 @@
     "@typescript-eslint/parser": "^7.1.0",
     "babel-plugin-ember-template-compilation": "^2.2.1",
     "concurrently": "^8.2.2",
-    "ember-basic-dropdown": "8.0.0-beta.7",
+    "ember-basic-dropdown": "8.0.0-beta.8",
     "ember-concurrency": "^4.0.0",
     "ember-source": "~5.6.0",
     "ember-template-lint": "^5.13.0",
@@ -143,7 +143,7 @@
     "@ember/test-helpers": "^2.9.4 || ^3.2.1",
     "@glimmer/component": "^1.1.2",
     "@glimmer/tracking": "^1.1.2",
-    "ember-basic-dropdown": "8.0.0-beta.7",
+    "ember-basic-dropdown": "8.0.0-beta.8",
     "ember-concurrency": "^4.0.0",
     "ember-source": "^3.28.0 || ^4.0.0 || >=5.0.0"
   },

diff --git a/ember-power-select/src/components/power-select.hbs b/ember-power-select/src/components/power-select.hbs
@@ -56,13 +56,13 @@
       {{on "blur" this.handleBlur}}
       class="ember-power-select-trigger {{@triggerClass}}{{if publicAPI.isActive " ember-power-select-trigger--active"}}"
       aria-activedescendant={{if dropdown.isOpen (unless @searchEnabled (concat publicAPI.uniqueId "-" this.highlightedIndex))}}
-      aria-controls={{if (and dropdown.isOpen (not @searchEnabled)) listboxId ""}}
+      aria-controls={{if (and dropdown.isOpen (not @searchEnabled)) listboxId}}
       aria-describedby={{@ariaDescribedBy}}
       aria-haspopup={{unless @searchEnabled "listbox"}}
       aria-invalid={{@ariaInvalid}}
       aria-label={{@ariaLabel}}
       aria-labelledby={{this.ariaLabelledBy}}
-      aria-owns={{if (and dropdown.isOpen (not @searchEnabled)) listboxId ""}}
+      aria-owns={{if (and dropdown.isOpen (not @searchEnabled)) listboxId}}
       aria-required={{@required}}
       aria-autocomplete={{if @searchEnabled "list"}}
       role={{or @triggerRole "combobox"}}