Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLN] Move validation logic to server #2709

Open
wants to merge 18 commits into
base: spike/generate_ids
Choose a base branch
from

Conversation

spikechroma
Copy link

@spikechroma spikechroma commented Aug 22, 2024

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Move validation logic for embedding set operations from client to server
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link
Author

spikechroma commented Aug 22, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spikechroma and the rest of your teammates on Graphite Graphite

@spikechroma
Copy link
Author

related issue: #164

Copy link
Contributor

@atroyn atroyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss

chromadb/api/models/CollectionCommon.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/api/segment.py Outdated Show resolved Hide resolved
chromadb/test/test_api.py Outdated Show resolved Hide resolved
chromadb/test/test_api.py Outdated Show resolved Hide resolved
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from 7a4db81 to 0247ba4 Compare September 13, 2024 21:50
@atroyn atroyn force-pushed the spike/generate_ids_move_validation branch from 0247ba4 to c2b44b6 Compare September 13, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants