Skip to content

Commit

Permalink
[BUG]: fix cross_version_persist assertion for >= 0.5.7 (#2824)
Browse files Browse the repository at this point in the history
  • Loading branch information
codetheweb committed Sep 19, 2024
1 parent edb0d27 commit 79b4a27
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions chromadb/test/property/test_cross_version_persist.py
Original file line number Diff line number Diff line change
Expand Up @@ -352,9 +352,15 @@ def test_cycle_versions(
embedding_function=not_implemented_ef(), # type: ignore
)

# Automatic pruning should be disabled since embeddings_queue is non-empty
embeddings_queue = system.instance(SqliteDB)
assert embeddings_queue.config.get_parameter("automatically_purge").value is False

# Automatic pruning should be disabled since embeddings_queue is non-empty
if packaging_version.Version(version) < packaging_version.Version(
"0.5.7"
): # (automatic pruning is enabled by default in 0.5.7 and later)
assert (
embeddings_queue.config.get_parameter("automatically_purge").value is False
)

# Update to True so log_size_below_max() invariant will pass
embeddings_queue.set_config(
Expand Down

0 comments on commit 79b4a27

Please sign in to comment.