Address comments

chroma-core · Sep 18, 2024 · 36a3bfc · 36a3bfc
1 parent da25a73
commit 36a3bfc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/chromadb/test/property/invariants.py b/chromadb/test/property/invariants.py
@@ -296,8 +296,6 @@ def ann_accuracy(
                 else:
                     continue
             else:
-                if not correct_distance:
-                    breakpoint()
                 assert correct_distance
 
             assert np.allclose(embeddings[index], query_results["embeddings"][i][j])

diff --git a/chromadb/test/property/test_embeddings.py b/chromadb/test/property/test_embeddings.py
@@ -799,13 +799,7 @@ def test_autocasting_validate_embeddings_for_compatible_types(
     validated_embeddings = validate_embeddings(Collection._normalize_embeddings(embds))
     assert all(
         [
-            isinstance(value, np.ndarray)
-            and all(
-                [
-                    isinstance(vec, (np.integer, np.floating)) and not isinstance(vec, bool)
-                    for vec in value
-                ]
-            )
+            isinstance(value, np.ndarray) and (value.dtype == np.float32 or value.dtype == np.float64 or value.dtype == np.int32 or value.dtype == np.int64)
             for value in validated_embeddings
         ]
     )
@@ -819,13 +813,7 @@ def test_autocasting_validate_embeddings_with_ndarray(
     validated_embeddings = validate_embeddings(Collection._normalize_embeddings(embds))
     assert all(
         [
-            isinstance(value, np.ndarray)
-            and all(
-                [
-                    isinstance(vec, (np.integer, np.floating)) and not isinstance(vec, bool)
-                    for vec in value
-                ]
-            )
+            isinstance(value, np.ndarray) and (value.dtype == np.float32 or value.dtype == np.float64 or value.dtype == np.int32 or value.dtype == np.int64)
             for value in validated_embeddings
         ]
     )