Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NmtBase.state always returns a string #506

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

erlend-aasland
Copy link
Contributor

Fixes #500

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (fa74236) to head (b871cf2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
+ Coverage   68.74%   68.75%   +0.01%     
==========================================
  Files          26       26              
  Lines        3116     3117       +1     
  Branches      527      526       -1     
==========================================
+ Hits         2142     2143       +1     
  Misses        837      837              
  Partials      137      137              
Files Coverage Δ
canopen/nmt.py 93.23% <100.00%> (+0.05%) ⬆️

@acolomb acolomb changed the title Ensure NmtBase.state return a string for unknown states Ensure NmtBase.state always returns a string Jul 9, 2024
@acolomb acolomb merged commit 5207b32 into christiansandberg:master Jul 9, 2024
3 checks passed
@erlend-aasland erlend-aasland deleted the nmt/state branch July 9, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NmtBase.state should always return a str
3 participants