Gracefully handle missing Baudrate setting in DCF #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CiA306 spec is not quite clear on which fields are mandatory within the DeviceComissioning section. Thus it should be assumed that the two options handled here could be missing. Instead of raising an exception, ignore the absence of the Baudrate setting.
erlend-aasland
approved these changes
Jul 3, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 67.84% 67.82% -0.03%
==========================================
Files 26 26
Lines 3107 3108 +1
Branches 524 525 +1
==========================================
Hits 2108 2108
Misses 859 859
- Partials 140 141 +1
|
|
I added tests for this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CiA306 spec is not quite clear on which fields are mandatory within the DeviceComissioning section. Thus it should be assumed that the two options handled here could be missing. Instead of raising an exception, ignore the absence of the Baudrate setting.