-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type annotations [WIP] #360
Conversation
What happens if you add mypy to GitHub actions (.github/workflows/pythonpackage.yml)? Does it pass or are there more things that need fixing? |
There are still some mypy issues remaining:
These are related to It is probably a great idea to incorporate mypy checks into GH actions workflow, but it is not yet implemented. |
I don't plan to implement this PR. Instead the type annotations will be split up into multiple PRs of suitable chunks which makes it easier to review. Closing this PR. |
With reference to discussion in #358, this PR adds typing annotations to canopen.
As of today, this branch is still work in progress and the annotation is not yet complete.
mypy is the primary type checker, however as [my] development is done in VSCode, the code is linted against pyright/pylance.
Closes #358