Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bundle create-react-class & allow Formsy to be used globally #463

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vonkruel
Copy link

Hi,

When I try to load Formsy-0.19.5 with a <script> tag, the page dies with this error:

create-react-class could not find the React object. If you are using script tags, make sure that React is being loaded before create-react-class.

This error happens even though React has been loaded with a <script> tag before loading Formsy with another <script> tag. If we treat create-react-class as external like react itself, the problem disappears. Is this acceptable?

@vonkruel vonkruel changed the title Don't bundle create-react-class & allow Formsy to be used globally. Don't bundle create-react-class & allow Formsy to be used globally Jul 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant