Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix infinity rerender with NaN value #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix infinity rerender with NaN value #460

wants to merge 1 commit into from

Conversation

nikmilson
Copy link

Using value={NaN} causes infinity rerender, because of isSame(NaN, NaN) returns false due to NaN === NaN is false (https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/NaN).

This PR fixes isSame function for this case. Test cases are added.

@nikmilson nikmilson closed this by deleting the head repository Jan 30, 2023
@nikmilson nikmilson reopened this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant