-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]: Users demo #44
Conversation
@snewcomer I might be doing something wrong locally but when I run your branch and try to delete a user I get an error message: Thanks for the fork though! I am trying to write a generic master-detail view where the master list updates when a new "thing" is created or when a "thing" is deleted. |
@jg-made great find 👍 I fixed and added a test |
@snewcomer thanks again! Great work on making it compatible with modern live view. |
@snewcomer I have another question please. I see that in UPDATE: OMG i actually figured it out. You need to add this line:
to the |
@@ -11,7 +11,7 @@ defmodule DemoWeb.UserLive.Index do | |||
{:ok, assign(socket, page: 1, per_page: 5)} | |||
end | |||
|
|||
def handle_params(params, url, socket) do | |||
def handle_params(params, _url, socket) do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add this line
if connected?(socket), do: Demo.Accounts.subscribe()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you thank you! Updated and nice job 👍
too many merge conflicts |
close #43 #51