Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh project #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refresh project #36

wants to merge 4 commits into from

Conversation

spiritdead
Copy link

good day i decided to share this with the comunity,

the first thing is the syntax is now the 5.6 (maybe not complete but many things)
i decide to use the standard PSR1/PSR2 in the code syntax
improved the worker scheduler
improved the workerPid()

… when the server is windows and the the PID, updated the scheduler worker, renamed the workers in the redis, and more changes
@@ -1,12 +1,16 @@
{
"name": "chrisboulton/php-resque-scheduler",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, and i rewrited this completly in OOP, from the begginning

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this PR makes this project yours.

Copy link
Author

@spiritdead spiritdead Apr 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#37

after talk with another collaborator, i decided make a rewrite of this, this project is very old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants