bugfix in timestamp allocation for scheduler worker #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankdebot
commented
Mar 14, 2016
frankdebot
commented
- fixed bug: if there are more than 1 items to be processed with different timestamps in the past, then the scheduler will sleep() before it picks up the next item in the past. If messages keep on being queued faster then 1 per second then eventually the scheduler cannot keep up
- fixed bug: if there are more than 1 items to be processed with different timestamps in the past, then the scheduler will sleep() before it picks up the next item in the past. If messages keep on being queued faster then 1 per second then eventually the scheduler cannot keep up
so it always gets the oldest timestamp before now. Timestamp should be defined for enqueueDelayedItemsForTimestamp
|
Hi. in our high traffic applications we encountered bugs in the way the scheduler works if it was temporarily disabled. If there are more items in the past to be processed, the non-patched version picks up 1 item and sleeps(1) till it picks up the next. This seems to be because of a logical bug. this patch fixes that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.