Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature composer autoload #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danhunsaker
Copy link
Contributor

Mirrors changes made in PHP-Resque for the same functionality.

@lboynton
Copy link

lboynton commented Nov 1, 2013

👍

@stevelacey
Copy link

@chrisboulton this looks pretty good, any reason this hasn't been merged?

@danhunsaker probably want to add this to the composer json to get the bin installed in vendor/bin:

    "bin": [
        "bin/resque-scheduler"
    ],

@chamindaindika
Copy link

chamindaindika commented Jul 20, 2018

@chrisboulton @danhunsaker @stevelacey ,

Will not this been merged with the repository? I think I'm struggling with an issue related to autoloading or something.

I'm using php-resque as the job queue in my project. And the composer package version of the repository is "dev-master". Because of that, I had to move to the dev-master of this resque-scheduler as well.

When I run the command to start the scheduler' worker, it's again start the queue worker in the first place and after I exit from the stdout, then it starts scheduler worker. Because of that, I can't automate the initialization of the scheduler. Below is the command I ran to start the service.

VVERBOSE=1 QUEUE='*' REDIS_BACKEND=$REDIS_HOST:$REDIS_PORT REDIS_BACKEND_DB=$REDIS_DATABASE INTERVAL=10 RESQUE_PHP=vendor/bin/resque php vendor/chrisboulton/php-resque-scheduler/resque-scheduler.php

I'm not sure about the place where the RESQUE_PHP is set. If it's not correct please let me know the correct way of starting the service. And also I feels that if we have the scheduler worker also as a vendor binary with the other changes (such as autoloading) of this pull request, then we can omit the setting of this environment variable in the command. Please correct me if am wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants