Fix imu report (linear acceleration and angular velocity) #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of acceleration and angular velocity fields are fixed so the reported values are correct. The axis orientation is positive X pointing right, positive Y pointing up, and positive Z pointing towards the user. For the angular velocities, the following convention is used for the names (following the right thumb rule): Roll: rotation around X axis Pitch: rotation around Y axis Yaw: rotation around Z axis The code has been tested by checking that the sign of the values are consistent with the axis orientation when translating/rotating the device. References: - https://gamedev.stackexchange.com/a/87178 - http://eleccelerator.com/wiki/index.php?title=DualShock_4#Report_Structure
The roll-pitch-yaw convention differs among industries, thus, is better to explicitly state the axis which rotation is considered. The field names also explicitly states that the values are "angular velocity" and "linear acceleration," as opposed to "orientation" and "motion," which are ambiguous (and technically incorrect).
naoki-mizuno
force-pushed
the
fix-imu-report
branch
from
73285db
to
7e5f220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that the linear acceleration and angular velocity reported from the device is incorrect. I looked into this problem and found that the order of fields were incorrect. With this PR the linear acceleration and angular velocity become consistent.
The following axis orientation is used (since I couldn't find any specific convention used in the code):
X: points to the right
Y: points up
Z: points towards the person holding the device
If needed I can post plots that I used to confirm that the fix is indeed consistent with the axis orientation above.
The following websites were references: