Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(build) Add templated notifications to all build configurations #1063

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

Windos
Copy link
Member

@Windos Windos commented Sep 17, 2024

Description Of Changes

This PR makes each build configuration in the TeamCity KTS file reference a template containing standard Slack notification configuration, which applies said configuration to the build configuration without having to duplicate it in each.

Motivation and Context

Enables standard notification configuration across all build configurations in this project.

Testing

This change was initially tested by pointing a development TeamCity instance at the equivalent changes on the chocolatey/choco project. These notification changes are now live for that project and have been operating in production for some time.

Operating Systems Testing

N/A

Change Types Made

Build configuration change (non-breaking)

* [ ] Bug fix (non-breaking change).
* [ ] Feature / Enhancement (non-breaking change).
* [ ] Breaking change (fix or feature that could cause existing functionality to change).
* [ ] Documentation changes.
* [ ] PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A

@Windos Windos added BuildAutomation Issues for changes to the build system, without functional changes needed to the project NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product 3 - Review Code has been added, and is available for review as a pull request labels Sep 17, 2024
@Windos Windos requested a review from gep13 September 17, 2024 03:45
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gep13 gep13 force-pushed the build/add-templated-slack-notif branch from 5ca5169 to d903e17 Compare September 23, 2024 15:58
@gep13 gep13 added this to the 2.2.0 milestone Sep 23, 2024
@gep13 gep13 merged commit 223b3d1 into chocolatey:develop Sep 23, 2024
2 checks passed
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Sep 23, 2024
@gep13
Copy link
Member

gep13 commented Sep 23, 2024

@Windos thanks for getting this updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Done Code has been added to the repository, and has been reviewed by a team member BuildAutomation Issues for changes to the build system, without functional changes needed to the project NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants