Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Allow better debugging of Chocolatey GUI #1024

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

gep13
Copy link
Member

@gep13 gep13 commented Sep 22, 2023

Description Of Changes

This commit introduces a change similar to what exists in Chocolatey CLI. While in debug mode, we source the installation location of both Chocolatey and the GUI Licensed assembly from a different location, rather than the official location.

Motivation and Context

This means that we can run the debug version of Chocolatey GUI using a locally sourced debug version of Chocolatey, which means that debugging some scenarios is much easier.

Testing

This PR should be tested alongside a PR into Chocolatey GUI Licensed, which makes use of this change.

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

N/A - This is merely for allowing better development experience when working with Chocolatey GUI

@gep13 gep13 added this to the 2.2.0 milestone Sep 22, 2023
@gep13 gep13 added BuildAutomation Issues for changes to the build system, without functional changes needed to the project NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product labels Sep 22, 2023
This commit introduces a change similar to what exists in Chocolatey
CLI.  While in debug mode, we source the installation location of both
Chocolatey and the GUI Licensed assembly from a different location,
rather than the official location.  This means that we can run
the debug version of Chocolatey GUI using a locally sourced debug
version of Chocolatey, which means that debugging some scenarios is
much easier.
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdmiringWorm AdmiringWorm merged commit a2a976c into chocolatey:develop Sep 22, 2023
2 checks passed
@AdmiringWorm
Copy link
Member

@gep13 great work on getting this added 👍

@gep13 gep13 deleted the allow-debugging branch September 22, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BuildAutomation Issues for changes to the build system, without functional changes needed to the project NO RELEASE NOTES Should not be included in the release notes - not enhancing or fixing end product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants