Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(GH-121) Implement ConfigurationHandler #135

Merged
merged 12 commits into from
Mar 3, 2019
Merged

(GH-121) Implement ConfigurationHandler #135

merged 12 commits into from
Mar 3, 2019

Commits on Mar 2, 2019

  1. (GH-121) Initial PoC

    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    0421d78 View commit details
    Browse the repository at this point in the history

  2. (GH-121) Refactoring of ConfigurationHandler 

    - Based on the work in this repository:
https://github.com/tintoy/msbuild-project-tools-server
- Needed updated due to changes in most recent version of Omnisharp
    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    122b1f1 View commit details
    Browse the repository at this point in the history

  3. (GH-121) Refactoring implementation 

    - Added new interface to provide up to date Configuration
- Changed Rule registrations.  Use container, rather than reflection
- This will mean that each rule has to be registered with container
    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    36f6f3b View commit details
    Browse the repository at this point in the history

  4. (GH-121) Corrected rebase

    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    aa70aa5 View commit details
    Browse the repository at this point in the history

  5. (maint) Formatting

    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    95b274c View commit details
    Browse the repository at this point in the history

  6. (maint) General refactoring 

    - Grouping all files into correct folders
- Changing namespaces, etc
    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    73610f2 View commit details
    Browse the repository at this point in the history

  7. (GH-121) Refactor to single rule per file

    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    c6112ee View commit details
    Browse the repository at this point in the history

  8. (GH-121) Only run validation is not suppressed 

    - Handle the case where there is no element
- Diagnostics are placed at top of file
    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    28f0f02 View commit details
    Browse the repository at this point in the history

  9. (GH-121) Changed method signature

    @gep13
    gep13 committed Mar 2, 2019
    Configuration menu
    Copy the full SHA
    627a941 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2019

  1. (GH-121) Refactored contributed configuration 

    - This will be a breaking change
- Allows for future expansion, and better grouping of related properties
- Removed mention of MSBuild
    @gep13
    gep13 committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    cacd8a5 View commit details
    Browse the repository at this point in the history

  2. (GH-121) Re-instated the TypeLocator 

    - To help with the registration of all validation rules
    @gep13
    gep13 committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    66b984c View commit details
    Browse the repository at this point in the history

  3. (GH-121) Added ValidationType to INuspecRule 

    - So that it is easy to identify rule types
    @gep13
    gep13 committed Mar 3, 2019
    Configuration menu
    Copy the full SHA
    2407102 View commit details
    Browse the repository at this point in the history