Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(ruby) migrated from ferventcoder #702

Merged
merged 4 commits into from
Apr 25, 2017
Merged

(ruby) migrated from ferventcoder #702

merged 4 commits into from
Apr 25, 2017

Conversation

majkinetor
Copy link
Contributor

@majkinetor majkinetor commented Apr 24, 2017

@majkinetor majkinetor added the Requires chocolatey-community User chocolatey-community user should be added to the list of package maintainers on Chocolatey Gallery label Apr 24, 2017
@majkinetor
Copy link
Contributor Author

This works for me, not sure why it fails on AV ...

@@ -0,0 +1,37 @@
import-module au
Import-Module "$PSScriptRoot\..\..\scripts\au_extensions.psm1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing " at the end
probably the reason why the appveyor run fails.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh... that line i changed in speed didnt have it locally. Thx.


## Package Parameters

- `InstallDir` - Ruby installation directory, by default `c:\tools\RubyXY` where XY are major and minor version parts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add / to the parameter keys.
There have been several times were users have reported they couldn't use packages with parameters,
It usually turned out that they was missing the / because the package parameters didn't mention it.

@majkinetor
Copy link
Contributor Author

Done, just add choco user

@AdmiringWorm
Copy link
Member

Sorry, can't add the choco user right now. The package page won't load for me, I'll have a look at it a little later.

@AdmiringWorm AdmiringWorm removed the Requires chocolatey-community User chocolatey-community user should be added to the list of package maintainers on Chocolatey Gallery label Apr 25, 2017
@AdmiringWorm
Copy link
Member

@majkinetor choco have been added.

@majkinetor majkinetor merged commit dbb026e into master Apr 25, 2017
@majkinetor majkinetor deleted the ruby branch April 25, 2017 14:47
@ferventcoder
Copy link
Contributor

This is a great start - however there are multiple running supported versions of Ruby at the same time (like VirtualBox but more). Did those get added to core team yet?

@ferventcoder
Copy link
Contributor

Case in point, https://rubyinstaller.org/

  • 2.2.6
  • 2.3.3 (this one is being managed)
  • upcoming 2.4.x

Also, where there plans to grab https://chocolatey.org/packages/ruby.portable as well?

@ferventcoder
Copy link
Contributor

@majkinetor issue 57 is about updating the certificates in the OLDER ruby versions, which means some additional functionality into a package version fix. HTH.

@majkinetor
Copy link
Contributor Author

@ferventcoder

Something like this is planned: majkinetor/au#74

@ferventcoder
Copy link
Contributor

I thought this was already supported in the way that we are doing it with VirtualBox?

@majkinetor
Copy link
Contributor Author

Yes, but it is a separate package. With above implementation all would go into the single package, stream would have 1 additional au_GetLatest function and reuse all other package data. I.E things are not dry and new package name is introduced which is not intuitive. We could go without a new package name, different AU folders could push to the same package id, but there would still need to be multiple almost identical package folders.

@majkinetor
Copy link
Contributor Author

Actually, I am a bit mistaken about VBox, I thought it pushes to the different VBox package id. AdmiringWorm did that so I wasn't totally aware how it functions up I looked at it now.

Still, it requires a separate folder and is treated as a separate AU package:

	virtualbox	        False	False	5.1.22	5.1.22
	virtualbox_5.0.x	False	False	5.0.40	5.0.32

so I guess it does make a sense to make it easier.

@AdmiringWorm
Copy link
Member

@majkinetor although it looks like a separate package, it reuses the original virtualbox scripts, and overrides the packagename variable so it pushes to the same chocolatey package.
Of course, when/if majkinetor/au#74 then the separate directory could be removed though. (Same thing with the php directories)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ruby) Migrate from ferventcoder
3 participants