-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#27)(#39)(#46)(#45) Rework and update the repository #47
base: master
Are you sure you want to change the base?
Conversation
…eferences Also removes template/example packages from ketarin
c4b07e5
to
2108e1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are minor corrections.
This all looks good to me. I can't comments on the appveyor scripts / yml file without running it. But at a glance it looks fine.
Thats for doing all this work @TheCakeIsNaOH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM, and it looks like most of the changes are similar to what is being used in https://github.com/chocolatey-community/chocolatey-packages. Before I put a final approval from me, though, I would like to test out the image used in the AppVeyor script in the above mentioned repository.
I'll schedule some time next week to make those changes in that repository and come back to this PR afterward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good to me (two minor comments) - but I think it's still waiting on testing of the AppVeyor changes.
Co-Authored-By: Miodrag Milić <[email protected]>
…ow a template repository
Co-Authored-By: James Ruskin <[email protected]>
@JPRuskin @TheCakeIsNaOH what are we waiting for? |
@Jaykul I'm waiting for review on this PR, it should be someone else that approves and merges this (or asks for changes). |
@AdmiringWorm have you looked at the appveyor changes? |
This is a major rework and update of the files in the repository. This removes ketarin references, switches au to chocolatey-au, and updates the scripts based on updates to the the majkinetor and chocolatey-community/chocolatey-packages repositories.
Fixes #27
Fixes #39
Fixes #45
Fixes #46