Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#49) Add migration page #50

Conversation

corbob
Copy link
Contributor

@corbob corbob commented Mar 18, 2024

Description Of Changes

Add a page for migrating from AU to Chocolatey AU.

Motivation and Context

See #49

Testing

N/A

Operating Systems Testing

N/A

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

Fixes #49

@corbob corbob self-assigned this Mar 18, 2024

## Updating Your Update Scripts

Once you have updated your repository to use the new module name, you will need to update your `update.ps1` scripts to use the new module name. This is as simple as replacing `AU` with `Chocolatey-AU` for any call to `Import-Module`, or any `#requires -Modules` in you `update.ps1` scripts.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth mentioning that if there is an import-module au in the update_all.ps1, it should be updated as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I've updated this to just specify updating it in your scripts so we're not calling out specific scripts.

@pauby
Copy link
Member

pauby commented Mar 19, 2024

In all the docs we've created, we add the URL's to the text as we're writing it rather than at the bottom (there's a name for that, and I cannot remember it). Can you add the URL's where the text is at?

Can you also change AU to AU and Chocolatey AU to Chocolatey-AU? That feels more appropriate as you are referencing module names (I prefer lowercase, but the names of the modules on PS Gallery are as they are here).

@pauby pauby self-requested a review March 19, 2024 07:22
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Copy link
Member

@pauby pauby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When writing documentation, refer to the Language and Grammar page of the Design docs. It has some requirements when writing headings.

Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
@corbob corbob force-pushed the 49-add-a-migration-guide-type-document branch from c0158d8 to 08f5c3f Compare March 20, 2024 21:36
@corbob corbob requested a review from pauby March 20, 2024 21:44
@corbob corbob force-pushed the 49-add-a-migration-guide-type-document branch from 08f5c3f to 91f9127 Compare April 6, 2024 02:20
corbob and others added 2 commits April 29, 2024 14:48
Update the names in README.md to Chocolatey-AU. Link to the files within
the repository using relative links instead of directly to the
repository. This will allow links to go to the correct versions instead
of just the latest version.
@corbob corbob force-pushed the 49-add-a-migration-guide-type-document branch from 91f9127 to f32b66d Compare April 29, 2024 21:51
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things, otherwise this looks good to me.

Plugins.md Outdated Show resolved Hide resolved
Migrating-AU-to-Chocolatey-AU.md Outdated Show resolved Hide resolved
@corbob corbob force-pushed the 49-add-a-migration-guide-type-document branch from f32b66d to 399292c Compare May 6, 2024 14:22
Copy link
Member

@AdmiringWorm AdmiringWorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll leave it up to @pauby to have a final look over it.

@@ -51,37 +51,37 @@ To set up plugin to create gist under your user name you need to give it your gi
2. Select a `Custom` Integration
3. Copy the unique webhook url listed in the dialog.
4. Update your appveyor environment variable with your unique webhook, and set the name to `gitter_webhook`.
5. Navigate to the `update_all.ps1` file in your repository, and update the `$Options` hashtable with the following
5. Navigate to the `update_all.ps1` file in your repository, and update the `$Options` hashtable with the following
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to note it, nothing needs to change.

The two trailing spaces would be deliberate here, it is forcing a line break if the Markdown parser uses soft line breaks.

GitHub seems to handle it though, but if we want this in other places at some point we might want to revert this change.

@pauby pauby merged commit b1180bc into chocolatey-community:develop May 14, 2024
1 check passed
@pauby
Copy link
Member

pauby commented May 14, 2024

Thanks for doing this @corbob !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a migration guide type document
4 participants