Fix creating ackChan too late in test.

chirpstack · Apr 11, 2023 · 17c9f8c · 17c9f8c
1 parent 58a1f4b
commit 17c9f8c
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/internal/backend/semtechudp/backend_test.go b/internal/backend/semtechudp/backend_test.go
@@ -442,6 +442,12 @@ func (ts *BackendTestSuite) TestTXAckRetryFailFail() {
 		{Status: gw.TxAckStatus_IGNORED},
 	}, cache.DefaultExpiration)
 
+	// Create ack channel
+	ackChan := make(chan *gw.DownlinkTxAck, 1)
+	ts.backend.SetDownlinkTxAckFunc(func(pl *gw.DownlinkTxAck) {
+		ackChan <- pl
+	})
+
 	// send a nack on the first downlink attempt
 	ack1 := packets.TXACKPacket{
 		ProtocolVersion: packets.ProtocolVersion2,
@@ -502,10 +508,6 @@ func (ts *BackendTestSuite) TestTXAckRetryFailFail() {
 	assert.NoError(err)
 
 	// validate final ack
-	ackChan := make(chan *gw.DownlinkTxAck, 1)
-	ts.backend.SetDownlinkTxAckFunc(func(pl *gw.DownlinkTxAck) {
-		ackChan <- pl
-	})
 	txAck := <-ackChan
 	assert.Equal(&gw.DownlinkTxAck{
 		GatewayId:  "0102030405060708",