Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow doesn't work when the github_token is not specified #33

Open
V0XNIHILI opened this issue Feb 1, 2024 · 1 comment
Open

Workflow doesn't work when the github_token is not specified #33

V0XNIHILI opened this issue Feb 1, 2024 · 1 comment

Comments

@V0XNIHILI
Copy link

V0XNIHILI commented Feb 1, 2024

Same issue is present for the formatter: chipsalliance/verible-formatter-action#17

In the README, it writes: "If you don't wish to use the automatic PR review, you can omit the github_token".

However, this doesn't seem to work for me, see example output log here: https://github.com/V0XNIHILI/parametrizable-floating-point-verilog/actions/runs/7738827016/job/21100439503?pr=23 (for code: V0XNIHILI/parametrizable-floating-point-verilog@0097a9d)

@tgorochowik
Copy link
Member

Thank you for the report!
I can confirm the issue, apparently https://api.github.com/repos/chipsalliance/verible/releases/latest is no longer accessible without the token.

I don't think we can do much about it for now, the workarounds I see is providing a specific verible version when used without github_token (to be verified if it works).

We probably need to update the README to reflect this.

Would you be willing to submit a PR with the update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants