Skip to content

Commit

Permalink
main/libcupsfilters: backport cve patch
Browse files Browse the repository at this point in the history
  • Loading branch information
nekopsykose committed Sep 26, 2024
1 parent 3e552e8 commit 466dc62
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 1 deletion.
33 changes: 33 additions & 0 deletions main/libcupsfilters/patches/cve.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
From 95576ec3d20c109332d14672a807353cdc551018 Mon Sep 17 00:00:00 2001
From: Zdenek Dohnal <[email protected]>
Date: Thu, 26 Sep 2024 23:09:29 +0200
Subject: [PATCH] cfGetPrinterAttributes5(): Validate response attributes
before return

The destination can be corrupted or forged, so validate the response
to strenghten security measures.

Fixes CVE-2024-47076
---
cupsfilters/ipp.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/cupsfilters/ipp.c b/cupsfilters/ipp.c
index 8d6a9b3d..db10cb3f 100644
--- a/cupsfilters/ipp.c
+++ b/cupsfilters/ipp.c
@@ -404,6 +404,14 @@ cfGetPrinterAttributes5(http_t *http_printer,
ippDelete(response2);
}
}
+
+ // Check if the response is valid
+ if (!ippValidateAttributes(response))
+ {
+ ippDelete(response);
+ response = NULL;
+ }
+
if (have_http == 0) httpClose(http_printer);
if (uri) free(uri);
return (response);
2 changes: 1 addition & 1 deletion main/libcupsfilters/template.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pkgname = "libcupsfilters"
pkgver = "2.0.0"
pkgrel = 1
pkgrel = 2
build_style = "gnu_configure"
configure_args = [
# TODO mupdf deptree
Expand Down

0 comments on commit 466dc62

Please sign in to comment.