update only comparison

chfast · Apr 12, 2022 · 4004a04 · 4004a04
1 parent 58c0c7f
commit 4004a04
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/include/intx/intx.hpp b/include/intx/intx.hpp
@@ -1120,7 +1120,7 @@ inline constexpr bool operator!=(const T& x, const uint<N>& y) noexcept
     return uint<N>(x) != y;
 }
 
-#if !defined(_MSC_VER) || _MSC_VER < 1916  // This kills MSVC 2017 compiler.
+#if 0 && (!defined(_MSC_VER) || _MSC_VER < 1916)  // This kills MSVC 2017 compiler.
 inline constexpr bool operator<(const uint256& x, const uint256& y) noexcept
 {
     auto xp = uint128{x[2], x[3]};
@@ -1137,7 +1137,11 @@ inline constexpr bool operator<(const uint256& x, const uint256& y) noexcept
 template <unsigned N>
 inline constexpr bool operator<(const uint<N>& x, const uint<N>& y) noexcept
 {
-    return subc(x, y).carry;
+    for (size_t i = uint<N>::num_words; i-- > 1; ) {
+        if (x[i] != y[i])
+            return x[i] < y[i];
+    }
+    return x[0] < y[0];
 }
 
 template <unsigned N, typename T,