Skip to content

Commit

Permalink
cpufreq: tegra194: remove opp table in exit hook
Browse files Browse the repository at this point in the history
[ Upstream commit de0e85b ]

Add exit hook and remove OPP table when the device gets unregistered.
This will fix the error messages when the CPU FREQ driver module is
removed and then re-inserted. It also fixes these messages while
onlining the first CPU from a policy whose all CPU's were previously
offlined.

 debugfs: File 'cpu5' in directory 'opp' already present!
 debugfs: File 'cpu6' in directory 'opp' already present!
 debugfs: File 'cpu7' in directory 'opp' already present!

Fixes: f41e144 ("cpufreq: tegra194: add OPP support and set bandwidth")
Signed-off-by: Sumit Gupta <[email protected]>
[ Viresh: Dropped irrelevant change from it ]
Signed-off-by: Viresh Kumar <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
  • Loading branch information
Sumit Gupta authored and gregkh committed Sep 13, 2023
1 parent 88dbf43 commit 002a658
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions drivers/cpufreq/tegra194-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -520,6 +520,17 @@ static int tegra194_cpufreq_offline(struct cpufreq_policy *policy)
* Preserve policy->driver_data and don't free resources on light-weight
* tear down.
*/

return 0;
}

static int tegra194_cpufreq_exit(struct cpufreq_policy *policy)
{
struct device *cpu_dev = get_cpu_device(policy->cpu);

dev_pm_opp_remove_all_dynamic(cpu_dev);
dev_pm_opp_of_cpumask_remove_table(policy->related_cpus);

return 0;
}

Expand Down Expand Up @@ -550,6 +561,7 @@ static struct cpufreq_driver tegra194_cpufreq_driver = {
.target_index = tegra194_cpufreq_set_target,
.get = tegra194_get_speed,
.init = tegra194_cpufreq_init,
.exit = tegra194_cpufreq_exit,
.online = tegra194_cpufreq_online,
.offline = tegra194_cpufreq_offline,
.attr = cpufreq_generic_attr,
Expand Down

0 comments on commit 002a658

Please sign in to comment.