chore: fix: update to oclif v3 instead of archived/obsolete oclif-dev v1 #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickboldt
changed the title
Change-Id: Ie5148a80ba50f1a125eebd6f10e2f099d276ee59 Signed-off-by: Nick Boldt <[email protected]> typo: depend on oclif, not @oclif Change-Id: I89ca3c931c154413caaa5bf55a1a58753ed70601 Signed-off-by: Nick Boldt <[email protected]> oclif 3 doesn't use a channel/foo/ path under dist/; also add shasum binary to work around missing shasum on fedora/rhel Change-Id: I768fa9e8a6a051e17115937efd8948cb95ec28d6 Signed-off-by: Nick Boldt <[email protected]> use prepack and pack-binaries from package.json instead of hardcoding 'npx oclif pack' Change-Id: I9b4e049b39908396f157be9bb58525b43bd6b885 Signed-off-by: Nick Boldt <[email protected]> tarball could be in dist/ or dist/channels/*/ Change-Id: I4c504162f0a9f70b9384c73ffc3efceb19f3eb07 Signed-off-by: Nick Boldt <[email protected]> wildcards for the filename, eg., ./dist/chectl-v0.0.2-71a78e3-linux-x64.tar.gz Change-Id: Ifbed461b4a75bd5c04c34036a041ab845c73fa21 Signed-off-by: Nick Boldt <[email protected]>
|
/retest |
9 tasks
tolusha
approved these changes
Sep 22, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nickboldt, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build 3.10 :: dsc_3.x/1385: Console, Changes, Git Data |
|
Build 3.10 :: dsc_3.x/1386: Console, Changes, Git Data |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
chore: fix: update to oclif v3 instead of archived/obsolete oclif-dev v1
Change-Id: Ie5148a80ba50f1a125eebd6f10e2f099d276ee59
Signed-off-by: Nick Boldt [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
related to https://issues.redhat.com/browse/CRW-4855
How to test this PR?
N/A
PR Checklist
As the author of this Pull Request I made sure that:
Reviewers
Reviewers, please comment how you tested the PR when approving it.