Sanity check examples to be packaged with binary distribution #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayantaylor
requested review from
ritvikrao,
matthiasdiener,
ZwFink and
adityapb
adityapb
reviewed
Sep 10, 2024
| TIMEOUT = 120 # timeout for each test (in seconds) | ||
|
|
||
| cmd = ["charmrun"] | ||
| cmd += ['++local'] |
There was a problem hiding this comment.
Are we only distributing the netlrts build with pip? What happens if you run with ++local with the MPI build?
There was a problem hiding this comment.
the pip binaries only include the netlrts build
|
I'm not 100% sure if these extra examples are really necessary - could they be confusing for the user? Could we tell the user something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding a set of examples that can be run via a command line interface after installing Charm4py from a binary distribution. These examples were copied from the examples folder.
TODO:
charm4pymodule causes the following warning to be printed after any minitest:Program is exiting but charm was not started: charm.start() was not called or error happened before startAs is, minitest cannot be placed insidetestsbecause tests is not a module.++localbe forced?