Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cffi and add local_msg test #230

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

slm960323
Copy link

  • Remove cffi from the github action autotest
  • Add task-bench to auto test
  • Add local_msg test file
  • Local_msg test failed with the current master

@slm960323 slm960323 self-assigned this Jan 26, 2022
@slm960323 slm960323 requested a review from ZwFink January 26, 2022 20:05
@ZwFink
Copy link
Contributor

ZwFink commented Jan 26, 2022

We should document that we are moving away from the CFFI and Ctypes backends, with Cython being the supported backend moving forward.

@slm960323
Copy link
Author

Charm4Py is trying to move away from cffi and use the Cython as the default.

Copy link
Contributor

@rbuch rbuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem unrelated to each other, perhaps they should be different, more descriptive commits?

- name: test-charm4py
run: |
git clone https://github.com/slm960323/task-bench.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this repo should be used in CI, it should be under the UIUC-PPL organization or made part of the charm4py repo, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants