Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the EKS job so you don't have type in the version information 5 times #1559

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Aug 14, 2024

Overview

Simplifies running the eks snap builds

Details

rather than running the job where you set the parameters

  • k8s_tag=v1.31.1
  • channels=1.31.1/edge,1.31.1/candidate,1.31.1/beta,1.31.1/stable

Now running the job where you set the parameters

  • k8s_tag=v1.31.1
  • channels=edge,candidate,beta,stable

  • include all snap risks rather than just edge,beta,candidate
  • build the snap channel list using some groovy split, amend, join magic 🪄

@addyess addyess force-pushed the akd/simplify-eks-snaps-build branch from 834052f to 847c4fc Compare August 14, 2024 19:47
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice improvement

@addyess addyess merged commit de292b3 into main Aug 20, 2024
6 checks passed
@addyess addyess deleted the akd/simplify-eks-snaps-build branch August 20, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants