-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better handling of subordinate departed states #214
base: main
Are you sure you want to change the base?
Conversation
…of a kubectl patch in k8s-common.
Looks good:
7 minutes is considerably better than the ♾️ minutes it was taking before. |
/hold to flesh this out in charmed-kubernetes/layer-kubernetes-common#28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this look pretty nice.
if dns_ip: | ||
return True, dns_ip, 53, dns_domain | ||
else: | ||
return False, None, None, None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random nit: this method could REALLY use some return typing
def get_dns_info() -> Tuple[bool, Optional[str], Optional[int], Optional[str]]:
if dns_ip: | |
return True, dns_ip, 53, dns_domain | |
else: | |
return False, None, None, None | |
if dns_ip: | |
return True, dns_ip, 53, dns_domain | |
return False, None, None, None |
@kwmonroe i'm still good with this one |
Lots of things don't work when control plane subordinates depart.
kubectl get $stuff
is especially troublesome as it takes forever to timeout. When we know our subs are going away, don't run things that callkubectl get $stuff
likeget_dns_ip
andconfigure_cdk_addons
.Fixes https://bugs.launchpad.net/charm-kubernetes-master/+bug/1968237