This repository has been archived by the owner on Aug 9, 2024. It is now read-only.
feat!: implement slurm snap to enable observability metrics collection for COS #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason C. Nucciarone <[email protected]>
Signed-off-by: Jason C. Nucciarone <[email protected]>
Keeps legacy code from old slurmctld_ops that still have not been enabled on the new manager. More focused on ensuring that observability works. Signed-off-by: Jason C. Nucciarone <[email protected]>
Still using some methods provided by the legacy manager that we don't have time to refactor this pulse Signed-off-by: Jason C. Nucciarone <[email protected]>
jedel1043
approved these changes
Jul 15, 2024
|
Merging as is. Verified that the Slurm snap is working within slurmctld and slurmd. Fixing outstanding issues with NHC (will rebase into experimental) and need to fix certain things with the juju-systemd-notices daemon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR takes a first stab at implementing the Slurm snap package within the slurmctld operator. It contains the Prometheus exporter which collects the metrics fed into COS.
This PR also adds a high-level interface for invoking
scontrol.scontrolenables us to easily control the cluster without needing to make constant updates to the Slurm configuration.How was the code tested?
Locally on my Ubuntu 24.04 Noble Numbat workstation.
Related issues and/or tasks
N/A
Checklist