Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: lfs http and jwt tests #351

Merged
merged 2 commits into from
Jul 28, 2023
Merged

feat: lfs http and jwt tests #351

merged 2 commits into from
Jul 28, 2023

Conversation

aymanbagabas
Copy link
Member

  • Add lfs, http, and jwt tests
  • Configure lfs settings
  • Validate lfs http requests

@aymanbagabas aymanbagabas mentioned this pull request Jul 25, 2023
Merged
3 tasks
@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (access-token@1c36bc1). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 70b1bd9 differs from pull request most recent head 1451864. Consider uploading reports for the commit 1451864 to get more accurate results

@@               Coverage Diff               @@
##             access-token     #351   +/-   ##
===============================================
  Coverage                ?   49.49%           
===============================================
  Files                   ?      135           
  Lines                   ?    10880           
  Branches                ?        0           
===============================================
  Hits                    ?     5385           
  Misses                  ?     5074           
  Partials                ?      421

@aymanbagabas aymanbagabas force-pushed the lfs-config branch 3 times, most recently from 915a76e to c50ee93 Compare July 26, 2023 21:29
caarlos0
caarlos0 approved these changes Jul 27, 2023
View reviewed changes
server/web/git.go Outdated Show resolved Hide resolved
@aymanbagabas aymanbagabas force-pushed the lfs-config branch 3 times, most recently from 2379ab0 to 3585140 Compare July 27, 2023 14:39
@aymanbagabas aymanbagabas mentioned this pull request Jul 28, 2023
Merged
@aymanbagabas
feat: add lfs config and tests
bcd0536 
Enable/disable LFS endpoints
Enable/disable SSH LFS transfer

fix: lfs request validation

chore: add jwt, lfs, and http tests

fix: tests race

feat: more tests

fix: return 403 on bad creds
@aymanbagabas
feat: use gorilla/mux
1451864
@aymanbagabas aymanbagabas merged commit ce94f9b into access-token Jul 28, 2023
13 of 15 checks passed
@aymanbagabas aymanbagabas deleted the lfs-config branch July 28, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aymanbagabas @caarlos0