slog: Don't log if not enabled at level (#103)

* slog: Don't log if not enabled at level * Update logger_121.go * chore: gofmt --------- Co-authored-by: Ayman Bagabas <[email protected]>
charmbracelet · Feb 5, 2024 · 7a3834f · 7a3834f
1 parent f2cb6b6
commit 7a3834f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/logger.go b/logger.go
@@ -15,10 +15,8 @@ import (
 	"github.com/muesli/termenv"
 )
 
-var (
-	// ErrMissingValue is returned when a key is missing a value.
-	ErrMissingValue = fmt.Errorf("missing value")
-)
+// ErrMissingValue is returned when a key is missing a value.
+var ErrMissingValue = fmt.Errorf("missing value")
 
 // LoggerOption is an option for a logger.
 type LoggerOption = func(*Logger)

diff --git a/logger_121.go b/logger_121.go
@@ -5,10 +5,9 @@ package log
 
 import (
 	"context"
+	"log/slog"
 	"runtime"
 	"sync/atomic"
-
-	"log/slog"
 )
 
 // Enabled reports whether the logger is enabled for the given level.
@@ -21,7 +20,11 @@ func (l *Logger) Enabled(_ context.Context, level slog.Level) bool {
 // Handle handles the Record. It will only be called if Enabled returns true.
 //
 // Implements slog.Handler.
-func (l *Logger) Handle(_ context.Context, record slog.Record) error {
+func (l *Logger) Handle(ctx context.Context, record slog.Record) error {
+	if !l.Enabled(ctx, record.Level) {
+		return nil
+	}
+
 	fields := make([]interface{}, 0, record.NumAttrs()*2)
 	record.Attrs(func(a slog.Attr) bool {
 		fields = append(fields, a.Key, a.Value.String())